Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global fitting via scripts is broken #19256

Closed
jmborr opened this issue Mar 27, 2017 · 9 comments
Closed

Global fitting via scripts is broken #19256

jmborr opened this issue Mar 27, 2017 · 9 comments
Assignees
@jmborr
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone
Release 3.10

Comments

@jmborr
Copy link
Member

jmborr commented Mar 27, 2017 •
edited

Pull request #18362 has broken the global fitting scripts in the script repository.

Benchmark data and script to test this:
fit_irs26176_with_Teixeira.py
irs26173_graphite_res.nxs
irs26176_graphite002_red.nxs

(This test will later be included as a system test. See #19249)
@jmborr jmborr added Component: Fitting Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. labels Mar 27, 2017
@jmborr jmborr added this to the Release 3.10 milestone Mar 27, 2017
@jmborr jmborr self-assigned this Mar 27, 2017
@jmborr
Copy link
Member Author

jmborr commented Mar 27, 2017

@mantid-roman I'm trying to find out what went wrong, but I'd appreciate it if you could give me a hand.

@mantid-roman
Copy link
Contributor

I'll have a look

@jmborr
Copy link
Member Author

jmborr commented Mar 27, 2017

thanks a lot!

@mantid-roman
Copy link
Contributor

@jmborr Could you explain what is broken?

@mantid-roman
Copy link
Contributor

I think I know what happened. Sorry it was my fault. The fitting parameters should be OK but the computed spectra are wrong. The fix is in the patch release and in master.

@jmborr
Copy link
Member Author

jmborr commented Mar 27, 2017

wow, that was fast. Can you please tell me the sha1 ID for the commit to master so that I can learn what needed to be fixed?

@mantid-roman
Copy link
Contributor

This is the pull request: #19161

@jmborr
Copy link
Member Author

jmborr commented Mar 27, 2017

I just compiled master, they're working fine now 😄

@jmborr
Copy link
Member Author

jmborr commented Mar 27, 2017

Fixed with #19161

@jmborr jmborr closed this as completed Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmborr jmborr

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Release 3.10
Development

No branches or pull requests
2 participants
@mantid-roman @jmborr