Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for Homebrew Casks #297

Open
Gummibando opened this issue Nov 29, 2023 · 30 comments
Open

False positives for Homebrew Casks #297

Gummibando opened this issue Nov 29, 2023 · 30 comments
Assignees
Labels

Comments

@Gummibando
Copy link

Gummibando commented Nov 29, 2023

Cask integration is awesome, but Latest now shows false positives for some casks as apparently the macOS bundle version string and the Homebrew version string differ. Both "Your version" apps shown in the screenshow are the latest versions, i.e. identical to the "New version".

Screenshot 2023-11-29 at 12 11 57
@mangerlahn
Copy link
Owner

mangerlahn commented Nov 29, 2023

This has been discussed in #285, #288 and #289, but since this issue here is still clean, I would like to use it as a task list for false positives.

Fixable:

  • Spotify
  • CoverLoad
  • Warp
  • Spitfire Audio
  • Sublime Text
  • Parallels Desktop
  • IntelliJ IDEA
  • Keyboard Maestro
  • p4merge
  • Opera
  • GitHub Desktop
  • Keybase
  • Cutter
  • Sublime Merge
  • MuseScore
  • Meld
  • Fig
  • Android File Transfer
  • Franz
  • Raspberry Pi Imager
  • Android Studio
  • Eclipse
  • OBSBOT_Webcam
  • DiffMerge
  • Gramps
  • Plex Media Server
  • Plex
  • Vero

@mangerlahn mangerlahn pinned this issue Nov 29, 2023
@mangerlahn mangerlahn self-assigned this Nov 29, 2023
@mangerlahn mangerlahn added the bug label Nov 29, 2023
@mangerlahn mangerlahn added this to the Version 0.10.1 milestone Nov 29, 2023
@kguidonimartins
Copy link

Also, the "Update all" button is not available.

image

@methbkts
Copy link

We can add VNC Viewer to the list

@trystero11
Copy link

All four of these are false positives: the apps themselves report no updates available.
image

@ShoyuWeenie
Copy link

Please add Elgato Control Center to the list:
CleanShot 2023-11-30 at 12 32 41@2x

@lansil
Copy link

lansil commented Dec 1, 2023

Screen Shot 2023-12-01 at 17 29 45 This is my false positive after update to 0.10. I hope this can help you.

@denisnzrvs
Copy link

Obsidian can be added to the list. Latest v.0.10, Obsidian shows v1.4.16 of the app and Installer version v.1.4.13, this might be the cause of the issue. No updates available through Obsidian itself.
image

@mangerlahn
Copy link
Owner

So if you open Obsidian, does the About screen state 1.4.16? According to this page, v1.4.16 has been released in mid-october.

@denisnzrvs
Copy link

Yep! The Obsidian app is updated differently than its installer. The app itself is with version 1.4.16, checked it before commenting. The Installer version is 1.4.13

@JLP04
Copy link

JLP04 commented Dec 3, 2023

I have two apps to add to this list: PrusaSlicer and Volanta

Screenshot 2023-12-03 at 4 14 14 PM Screenshot 2023-12-03 at 4 14 18 PM

@mangerlahn
Copy link
Owner

@denisnzrvs can you send me a link to the Obsidian installer? Downloading from the website gives me a .app directly (with the correct version number)

@denisnzrvs
Copy link

@mangerlahn did some digging - the Installer comes with the app itself.

Obsidian is an Electron app which (as you may know), means it’s like a web app packaged in its own browser. The installer version refers to the “browser”, which Obsidian can’t update itself. That’s why we have this unfortunate 2-layered update system.

Source: https://forum.obsidian.md/t/newbie-some-advice-about-the-latest-necessary-installer-upgrade-and-also-backups/51268

Here's how the update section of the About screen looks for me btw.
image

@WillFulmer
Copy link

New MacOS Spotify version
image

But Latests show:
image

@jostrasser
Copy link

jostrasser commented Dec 9, 2023

Latest - Version 0.10.1 (1168)

Office for Mac versions:
image

Example "Word":
image

All up 2 date:
image


"Jabra Firmware Update" is part of the Software "Jabra Direct" and cannot be updated directly via "Latest"... should be completely ignored:

image

image

image

@martincampbell
Copy link

I see exactly the same problem as @jostrasser with Microsoft Office for Mac in Latest version 0.10.1

@trystero11
Copy link

Latest shows an incorrect current-version string for Microsoft Teams for macOS (Sonoma 14.1.2, if it matters) and reports a non-existent newer version as available that Teams itself doesn't find.

Latest:
image

Microsoft Teams when I select Microsoft Teams classic > About Microsoft Teams:
image

Note that Latest omits the ".6" in the current version as well as reporting that there's a newer version (which neither Teams nor Microsoft Auto-Update finds on my system).

@Stanzilla
Copy link

Google Chrome Beta-2023-12-13-17 22 53
Google Chrome Beta-2023-12-13-17 23 12

@trystero11
Copy link

On macOS Sonoma 14.2, Latest reports my current Slack version correctly but offers me a newer version that's not actually available on the Slack for Mac download page:
Latest-Slack-versions
Slack-download-page

The newer version appears to be the download from the beta release channel (which I'm not in):
Slack-beta-download-page

@fuzzy76
Copy link

fuzzy76 commented Dec 22, 2023

Skjermbilde 2023-12-22 kl  09 07 24

There is a Texts cask, but that is for a completely different app. What you're seeing here is a side-effect of showing homebrew updates for apps that haven't been installed using homebrew. This creates all kinds of problems ranging from different release channels to apps with the same name (I've encountered several in my time) to manual/private builds.

@mangerlahn
Copy link
Owner

Please provide the app's bundle identifier, so that I can put it on the ignore list.

@fuzzy76
Copy link

fuzzy76 commented Dec 22, 2023

com.kishanbagaria.jack

@jun6lee
Copy link

jun6lee commented Dec 26, 2023

Latest shows 0.10.3 pending (via homebrew), it's unreleased here, so I guess that means the cask rb can't be updated?
https://github.com/Homebrew/homebrew-cask/commits/cc79ccbcb9b7ca67173b7582c4f7d49d974afb7c/Casks/l/latest.rb

@jun6lee
Copy link

jun6lee commented Dec 26, 2023

Screenshot 2023-12-26 at 3 54 00 PM

https://github.com/Homebrew/homebrew-cask/blob/master/Casks/l/local.rb
Here I think we have two naming conventions clashing.

@alex-ioma
Copy link

Reporting two additional casks as per #342

Screenshot 2024-01-18 at 12 27 13 AM

Possibly:

  • Lens "installed" in Latest matches the actual installed version of the app, but the app does not report the update from latest as available update. Is it possible that the Latest is searching into beta channel for Lens?
  • Obsidian already updated but Latest possibly is looking at the installer / cached version of the installer rather that what is running in app (electron).
Screenshot 2024-01-18 at 12 30 21 AM

Thanks!

@JLP04
Copy link

JLP04 commented Jan 19, 2024

Bundle identifiers com.bambulab.bambu-studio and net.maxon.cinebench. See #342.

@mangerlahn
Copy link
Owner

Latest shows 0.10.3 pending (via homebrew), it's unreleased here, so I guess that means the cask rb can't be updated? https://github.com/Homebrew/homebrew-cask/commits/cc79ccbcb9b7ca67173b7582c4f7d49d974afb7c/Casks/l/latest.rb

Thanks for pointing that out @jun6lee, I just forgot to release that version.

@fuzzy76
Copy link

fuzzy76 commented Mar 25, 2024

SpeedCrunch.app

I cannot figure out the bundle identifier:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>CFBundleDevelopmentRegion</key>
	<string>English</string>
	<key>CFBundleExecutable</key>
	<string>SpeedCrunch</string>
	<key>CFBundleGetInfoString</key>
	<string></string>
	<key>CFBundleIconFile</key>
	<string>speedcrunch.icns</string>
	<key>CFBundleIdentifier</key>
	<string></string>
	<key>CFBundleInfoDictionaryVersion</key>
	<string>6.0</string>
	<key>CFBundleLongVersionString</key>
	<string>Version;master</string>
	<key>CFBundleName</key>
	<string></string>
	<key>CFBundlePackageType</key>
	<string>APPL</string>
	<key>CFBundleShortVersionString</key>
	<string>master</string>
	<key>CFBundleSignature</key>
	<string>????</string>
	<key>CFBundleVersion</key>
	<string></string>
	<key>CSResourcesFileMapped</key>
	<true/>
	<key>NSHumanReadableCopyright</key>
	<string></string>
</dict>
</plist>

@Gummibando
Copy link
Author

@fuzzy76

SpeedCrunch.app
I cannot figure out the bundle identifier:

Try Terminal mdls -name kMDItemCFBundleIdentifier -r /path/to/SpeedCrunch.app

@fuzzy76
Copy link

fuzzy76 commented Mar 25, 2024

@Gummibando returns empty string

@Gummibando
Copy link
Author

@fuzzy76

Identifier indeed appears to be missing. Qt app, they likely forgot to set the identifier in the respective project config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests