Update to Lunr 2.0.3 #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am using this PR in production. So, hearty +1 |
|
Then maybe the problem was with my setup, good to know 👍 Before merging we might want to:
|
|
@matiasgarciaisaia would you consider minifying lunr.js manually on every update for now? If you don't mind we can get this PR merged 💃 |
|
Please merge this. Searching is severely impaired using the old version. |
|
I hope someone from this Org merge this too 🙏 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
After implementing the new Lunr API changes all seems fine, and the specified pages are indexed. But after refreshing search.json in the browser was empty again.
@matiasgarciaisaia maybe you have some insights on what might be the problem?