Remove non-lmdb stores from unit tests #1566
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/tests/unit/arcticdb/version_store/test_aggregation_dynamic.py
Outdated
Show resolved
Hide resolved
|
Moved the test_fork test to integration as it seems sensible to test this with a s3 simulation at least |
…ersion_store in test_parallel_reads function
|
Are we sure this is a good idea? Azurite and Mongo are quite irritating in that they mostly fail locally, but S3 is the storage that the vast majority of our users actually use. This means we're removing more than half the tests in the whole project from the one storage that actually matters to the majority of people, which seems like a high price to pay for knocking a few minutes off a CI run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1564
What does this implement or fix?
It remove all simulators from the unit tests (e.g. S3 moto, azurite, mongo)
TODO - make sure that we don't need these tests, if we don - add them to the integration tests