Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalise behaviour when a column or date range is requested that does not exist #1558

Open
alexowens90 opened this issue May 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@alexowens90
Copy link
Collaborator

alexowens90 commented May 8, 2024

The behaviour should probably be the same in the following cases:

  • Straight read requesting a column that does not exist, or date range outside that covered by the symbol's index
  • QueryBuilder processing that depend on a column, or date range in the case of resampling or a date_range clause followed by other processing steps.

As it stands:

  • Straight read requesting a column that does not exist returns an empty dataframe with no rows or columns
  • Straight read requesting a date range outside the symbol's index returns an empty dataframe with no rows, and only columns specified to be included
  • QueryBuilder behaviour depends on whether the supplied queries can be combined with column selection, and whether the columns argument to read has also been provided
@alexowens90 alexowens90 added the bug Something isn't working label May 8, 2024
@alexowens90 alexowens90 changed the title Rationalise behaviour when a column is requested that does not exist Rationalise behaviour when a column or date range is requested that does not exist May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant