Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align how timeout setting act on S3 and Azure storage #1494

Open
phoebusm opened this issue Apr 12, 2024 · 0 comments
Open

Align how timeout setting act on S3 and Azure storage #1494

phoebusm opened this issue Apr 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@phoebusm
Copy link
Collaborator

phoebusm commented Apr 12, 2024

https://github.com/aws/aws-sdk-cpp/blob/64f29bce3a497111c2ab272bcb50ac5d568d5573/src/aws-cpp-sdk-core/source/http/crt/CRTHttpClient.cpp#L468
https://github.com/Azure/azure-sdk-for-cpp/blob/17c3cb50f158005497860525a07e23718e7d8878/sdk/core/azure-core/inc/azure/core/context.hpp#L240

Currently, 200000ms is the universal setting of request_timeout for both S3 ans Azure storage. However, the setting on S3 monitors at a more finer level - at each http request. For Azure, the setting monitors at a more granular level - at the entire API call.
It needs to be addressed, as it has created unwanted timeout in #1026. Or it needs to be dropped per #1487 (review), to rely on curl timeout completely.

@phoebusm phoebusm added the enhancement New feature or request label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant