Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py-rattler] AttributeError: 'NoneType' object has no attribute 'text' when a PathsEntry has no filemode #648

Closed
iamthebot opened this issue May 9, 2024 · 2 comments
Closed

[py-rattler] AttributeError: 'NoneType' object has no attribute 'text' when a PathsEntry has no filemode #648

iamthebot opened this issue May 9, 2024 · 2 comments
Labels
python-bindings

Comments

@iamthebot
Copy link
Contributor

This is semi related to #621 (in the sense that FileMode is exposed as a series of boolean properties currently in Python vs. an enum).

Looks like the current implementation will throw an AttributeError is a path data entry doesn't have a FileMode defined (which will be the case if there's no prefix placeholder) because the _inner object won't be defined on FileMode.

The most direct fix for this is to just return False for the text and binary properties in this case. At least until we address #621
@iamthebot
Copy link
Contributor Author

I wrote some of this code so I'll push a PR up for this tonight/tomorrow morning @baszalmstra

@iamthebot iamthebot mentioned this issue May 10, 2024
Merged
baszalmstra pushed a commit that referenced this issue May 10, 2024
@iamthebot
fix: Address (#648) Missing FileMode causes an AttributeError in py-r…
ab2bd4d 
…attler and fix missing properties (#651)
@iamthebot
Copy link
Contributor Author

This was closed by #651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python-bindings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baszalmstra @iamthebot