Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip writing sha256_in_prefix if it is the same as the original sha256 #471

Open
wolfv opened this issue Jan 9, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@wolfv
Copy link
Member

wolfv commented Jan 9, 2024

Rattler currently writes both sha's, even if they are identical:

    - _path: site-packages/pip/_internal/commands/wheel.py
      path_type: hardlink
      sha256: 99b14977876651fad51499106caf27db31f245c0f7008f757fb114a3d9772988
      sha256_in_prefix: 99b14977876651fad51499106caf27db31f245c0f7008f757fb114a3d9772988
      size_in_bytes: 7396

I think we should write only sha256, and if they are not identical, also write the sha256_in_prefix. IIRC that is how conda handles it.

@baszalmstra baszalmstra added the enhancement New feature or request label Feb 29, 2024
@iamthebot
Copy link
Contributor

Hmm weirdly in a few local environments I have cases where the shas are identical in a conda-meta file for sha256 and sha256_in_prefix. Does mamba not implement the same behavior as conda here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants