Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel renaming #536

Open
gabm opened this issue May 19, 2022 · 3 comments
Open

Channel renaming #536

gabm opened this issue May 19, 2022 · 3 comments

Comments

@gabm
Copy link
Contributor

gabm commented May 19, 2022

Currently the channel names are fixed as they are used as primary keys/ids for everything else in the DB. Would it be possible to use the current channel_name as "channel_id" and fill it with a fixed UUID for internal cross-references and add a new "channel_name" column for the public interface?

This way we could safely provide an API to rename channels...

@wolfv
Copy link
Member

wolfv commented May 19, 2022

Hi @gabm, thanks for the suggestion.
We actually do have the same problem with the package store (where we also use the channel name as "folder" to store the files in).
So it would break a couple of assumptions that are in the code base currently.

I am also wondering how often (in practice) channels would be renamed... it should ideally happen fairly seldomly :)

@gabm
Copy link
Contributor Author

gabm commented May 19, 2022

I am also wondering how often (in practice) channels would be renamed... it should ideally happen fairly seldomly :)

yes.. but making it impossible in the first place seems overly restrictive :)

So I understand, at least for the time being, there is no interest in such a patch?

@wolfv
Copy link
Member

wolfv commented May 19, 2022

Certainly there is an interest in such a patch but it will be tricky.

– existing instances need to migrate their data store
– we need to make sure that performance is similar
– the database will have to be migrated

I just think that we have other subjects in the quetz code base that need fixing more urgently :) But if you want to tackle this, feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants