Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup #97

Open
1 of 3 tasks
maltejur opened this issue Feb 7, 2023 · 3 comments
Open
1 of 3 tasks

Code Cleanup #97

maltejur opened this issue Feb 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@maltejur
Copy link
Owner

maltejur commented Feb 7, 2023

If I find the time, the code is in dire need of a cleanup. Main things to do:

  • Use QWebChannel for communicating between the userscript and the main process instead of the hacky one-way console communication I am doing right now
  • Update the virmic code to use the latest version of rohrkabel (Change the way the Virtual-Mic works #26) and avoid creating a new process for the virtmic
  • Improve the way UI elements are injected into the dom
@maltejur maltejur added the enhancement New feature or request label Feb 7, 2023
@doubledge-spec
Copy link

any update? I've seen progress on the virtmic since that time i stupidly tried to push for that merge request.

@Curve
Copy link

Curve commented Sep 17, 2023

Shameless plug right here, but for the Userscript communication you might be interested in saucer ^^

@maltejur
Copy link
Owner Author

Ohh, interesting. As I mentioned, I have switched over to QWebChannel a while ago, so the cross-communication is not as bad as it used to be, and I probably want to stick with QWebChannel for now. But definitely looks nice, maybe I'll have the chance to try it with a new project at some point.

@maltejur maltejur pinned this issue Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants