Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing framerate and resolution in UI doesn't change the streamed framerate and resolution #221

Open
sourcelocation opened this issue Dec 24, 2023 · 3 comments

Comments

@sourcelocation
Copy link

When I select 60 FPS and 1080p on a server with boosts and begin to stream, on my end it shows the correct information in the top right corner, but the stream itself is only 30fps 720p always.

logs:

...
[discord] [UnifiedConnection(default)] Renegotiating: Streams changed
[discord] [UnifiedConnection(default)] updateVideoQuality: {
[discord]     "encodingVideoWidth": 1280,
[discord]     "encodingVideoHeight": 720,
[discord]     "encodingVideoFrameRate": 30,
[discord]     "remoteSinkWantsMaxFramerate": 30,
[discord]     "remoteSinkWantsPixelCount": 921600,
[discord]     "encodingVideoBitRate": 2500000,
[discord]     "encodingVideoMinBitRate": 150000,
[discord]     "encodingVideoMaxBitRate": 2500000,
[discord]     "streamParameters": [
[discord]         {
[discord]             "type": "video",
[discord]             "active": false,
[discord]             "rid": "100",
[discord]             "ssrc": 208693,
[discord]             "rtxSsrc": 208694,
[discord]             "quality": 100,
[discord]             "maxBitrate": 2500000,
[discord]             "maxFrameRate": 30,
[discord]             "maxResolution": {
[discord]                 "type": "fixed",
[discord]                 "width": 1280,
[discord]                 "height": 720
[discord]             },
[discord]             "maxPixelCount": 921600
[discord]         }
[discord]     ]
[discord] }
...

Any idea what could be going here? Thanks in advance!

@JJ-VP
Copy link

JJ-VP commented Dec 27, 2023

I can reproduce this issue, I set my stream quality to 4k, 144fps (or any other setting) and everything looks fine on my end, stream preview is high res and high fps. Join the call in a second client or have one of my friends join, stream quality for them is always 720p 30fps.

@thndgonz
Copy link

I can reproduce this issue, I set my stream quality to 4k, 144fps (or any other setting) and everything looks fine on my end, stream preview is high res and high fps. Join the call in a second client or have one of my friends join, stream quality for them is always 720p 30fps.

I've been debugging this on my desktop/qtcreator/chromium for a while but ended up giving up. I feel like I was just reinventing the wheel at the end.

Turns out that vencord has fixed everything... everything just works. Video sharing reflects exactly what it is expected to. Audio sharing works. vencord also has entire screen and single-application support.

As much as I wanted to help it's just a time sink but I still appreciate all the knowledge I got from this

@JJ-VP
Copy link

JJ-VP commented Dec 28, 2023

Turns out that vencord has fixed everything... everything just works. Video sharing reflects exactly what it is expected to. Audio sharing works. vencord also has entire screen and single-application support.

I have been using Vesktop as a replacement (I assume that is what you mean when you say Vencord) it has its own problems namely frame drops when there is lots of movement but overall seems like a pretty solid alternative. Defentily recommend anyone else getting annoyed by the above issue to give Vesktop a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants