Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant c fix #72

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Constant c fix #72

wants to merge 3 commits into from

Conversation

shal10w
Copy link

@shal10w shal10w commented Mar 13, 2023

  • convert the parameter C to a variable computed in the function
  • recompute some examples

the estimated results in classical model seems to change too.Because the default value of a is NN_AGPS["list_decoding-classical"]["A"] = 0.296, not 0.292.
fixes #71

@malb
Copy link
Owner

malb commented Feb 3, 2024

Thanks and sorry for the delay, could you rebase and resubmit. I'll respond quicker this time, I promise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kyber reduction model seems to use the wrong constant C in quantum mode
2 participants
@shal10w @malb