Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multi paths (eg: USDC-> BNB ->UNI) #7

Open
makoto opened this issue Mar 9, 2021 · 0 comments
Open

Support Multi paths (eg: USDC-> BNB ->UNI) #7

makoto opened this issue Mar 9, 2021 · 0 comments

Comments

@makoto
Copy link
Owner

makoto commented Mar 9, 2021

Description

It currently only supports a few stable coin swaps mainly because other swaps do not have direct pairs.

Ideally, it should make use of besttradeexactin function provided by Uniswap SDK but there are 2 challenges doing so.

  • sdk has the router address hardcoded
  • to derive the best path, you have to pass each available pairs as done in uniswap-interface code

Option 1 (Preferred)

Make a separate library that simplifies the function call to derive the best path. Ideally, I would like to have the function as easy as 1inch quote-swap API (The reason I just don't use their API is that they currently only support L1 and BSC. I would like to have platform-agnostic tool).

Option2 (Less preferred)

Make use of the existing fork SDK of each uniswap clones to derive the best path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant