Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dwell Time does not handle case of when all dwell times are 1 for a symbol #93

Open
Saqibm128 opened this issue Sep 22, 2022 · 2 comments

Comments

@Saqibm128
Copy link

image

r_diff evaluates as 1 for all elements, which yields a zero length array.

we should handle this as an edge case

@makism
Copy link
Owner

makism commented Sep 24, 2022

good catch 👍🏻

I think something like that could work:

if len(symbols) == 1:
    raise Exception("explanation here")

what do you think?

feel free open a PR, otherwise, I will tackle it ;)

@Saqibm128
Copy link
Author

Check and see if this is what you wanted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants