Questions

[gbalabasquer]

Quick questions, any reason why not to use the src directory for the solc files?
Also, are we committing the bin directory for any special purpose? As I see we have the bytecode hardcoded in test.sh.

[gbalabasquer]

Why does the second computeAddress function calls bytecode as bytecodeHash and then we have bytecodeHashHash? Shouldn't just be bytecode and bytecodeHash or am I missing anything?

[wilbarnes]

The script mimics the spellbook and copies the spell to src/ and then replaces the _CREATE2_ and _DEPLOYHASH_ variables. Then, once the script is over it deletes the contents of the src/ folder.

The create2 contract is actually the OpenZeppelin library. I have no idea why they did that: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/Create2.sol

[gbalabasquer]

Thanks. I'll keep it open just in case new questions show up.
Regarding the Create2 I'd suggest to rename that, it is a bit confusing.

[Emma34555]

I need eth