Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃摎 Docs]: UNSPLASH_API should not be Optional #77

Open
yahu1031 opened this issue Sep 8, 2023 · 0 comments
Open

[馃摎 Docs]: UNSPLASH_API should not be Optional #77

yahu1031 opened this issue Sep 8, 2023 · 0 comments

Comments

@yahu1031
Copy link

yahu1031 commented Sep 8, 2023

Issue

Issue with the UNSPLASH_API being optional is, as of the dio interceptors we have, on error such as 401 status code will navigate us back to onboarding screen. An we get this 401 from unsplash api with this endpoint https://api.unsplash.com/photos/?client_id=&page=1&per_page=18 where the client ID is empty.

Fix

In the readme docs Line 46

2. Define the variables BASE_API (required) and UNSPLASH_API_KEY (optional) in the `.env` file and initialize them.

Should be updated to make it mandatory (recommended) or providing some free API KEY will also solve this.

@yahu1031 yahu1031 changed the title UNSPLASH_API should not be Optional [馃摎 Docs]: UNSPLASH_API should not be Optional Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant