Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Viewshed Analysis against other Viewshed Implementations #669

Open
yiftachn opened this issue Feb 22, 2022 · 3 comments
Open

Test Viewshed Analysis against other Viewshed Implementations #669

yiftachn opened this issue Feb 22, 2022 · 3 comments
Assignees
Labels

Comments

@yiftachn
Copy link

Has anyone tested the correctness of the viewshed analysis output?
Assuming ESRI's ArcGIS as the ground truth, as it is the most popular, paid, solid and established viewshed product,
Does xarray-spatial viewshed returns identical output?

@yiftachn yiftachn added the bug Something isn't working label Feb 22, 2022
@ianthomas23 ianthomas23 removed the bug Something isn't working label Feb 24, 2022
@ianthomas23
Copy link
Contributor

ianthomas23 commented Feb 24, 2022

Personally I don't trust any mathematical software unless I can verify that the maths is implemented correctly.

It you want to compare the two, feel free to do so and report your results here if you wish.

@brendancol
Copy link
Contributor

@yiftachn We may have a test to check against GDAL's viewshed which was the inspiration for this tool. @davidnfox I think we should also test against Esri just to know how different the two are.

@brendancol brendancol changed the title Correctness of viewshed analysis Test Viewshed Analysis against other Viewshed Implementations Apr 29, 2022
@yiftachn
Copy link
Author

yiftachn commented May 2, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants