Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtxpy hillshade does not handle np.nan values #611

Open
ianthomas23 opened this issue Dec 22, 2021 · 0 comments
Open

rtxpy hillshade does not handle np.nan values #611

ianthomas23 opened this issue Dec 22, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@ianthomas23
Copy link
Contributor

GPU code seems to hang if the supplied cupy-backed xarray.DataArray contains np.nan values. Need to check rtxpy viewshed for the same problem.

Possible solutions:

  1. Keep the np.nan values (and np.inf too?) and deal with them gracefully.
  2. Check for existence of non-finite values and raise an exception.
  3. Document the limitation.
@ianthomas23 ianthomas23 added the bug Something isn't working label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Xarray-Spatial
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianthomas23