-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests to perform: #5
Comments
It's hard to know what would be best, currently we rely on the default Golang implementation for the DNS lookup which seems to prefer IPv6.
Currently they will fail. It will also help block MIM attacks and TLS certs are easy enough to generate so I think it's good.
If initiating with TLS fails, it will fallback to clear with STARTTLS. If STARTTLS isn't available it will eventually fallback to unsecure. |
So the priority is on port then? I think that's best to make sure we go through secure connection.
I need to double check this when I reimplement certificate authentication, because I had to add the self-signed CA when I tested it. Hopefully this is circumvented in SMTP until the auth step. I don't think there are other situations where you would have self-signed certificates. If it's on a private network, you would also self-host mailout and have control of the system's trust authority.
I think that port 465 should be handled differently and only allow if initial TLS passes. Mostly because if it fails, it means there is a missconfiguration and the user relyes on port 465 to be TLS by design, otherwise they'd be using 587. |
587
and port465
.The text was updated successfully, but these errors were encountered: