Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthening the NAS Library against Security Vulnerabilities #15388

Open
panyogesh opened this issue Mar 4, 2024 · 5 comments
Open

Strengthening the NAS Library against Security Vulnerabilities #15388

panyogesh opened this issue Mar 4, 2024 · 5 comments
Labels
type: proposal Proposals and design documents

Comments

@panyogesh
Copy link
Contributor

panyogesh commented Mar 4, 2024

Problem

Issues in existing NAS design

  • Mostly in C having exposed pointers and buffer overflow challenges
  • Vulnerable to malicious UEs
  • Not using new constructs of modern C++

Solution

Redesigning of existing NAS library making it robust using C++ constructs.

References

Timeline & Cost

  • Planning to do it in 2 phases. of roughly 3 Months each
  • Phase-I consist of 4G coding and testing
  • Phase-II consist of 5G coding and testing
  • Total amount will be $12,000
@panyogesh panyogesh added the type: proposal Proposals and design documents label Mar 4, 2024
@panyogesh panyogesh changed the title Hardening of NAS Library for security vulnerabilites Strengthening the NAS Library against Security Vulnerabilities Mar 4, 2024
@lucasgonze
Copy link
Contributor

Would you consider the AssertFatal cleanup in scope?

@lucasgonze
Copy link
Contributor

Nathaniel Bennett may submit patches for some parts of this. Let's find out more about what he can and can't cover.

@lucasgonze
Copy link
Contributor

lucasgonze commented Mar 27, 2024

We discussed his patches today, as well as the malicious inputs discovered through fuzzing with AFLplusplus.

  1. Nathaniel will submit C patches this week for inclusion in 1.9
  2. Yogesh to incorporate those patches in the C++ port
  3. Tests to be developed for checking the C patches and preventing regressions in the C++. Nathaniel to share the specific payloads that lead to crashes.

@lucasgonze
Copy link
Contributor

@panyogesh I believe these have been merged. Is that right?

@panyogesh
Copy link
Contributor Author

panyogesh commented May 20, 2024

#15401 : There is a minor comment provided to the author. It will unblock the merge (some mandatory CI jobs are failing(.
Once addressed it will be merged on master. Post CI Job it will be merged on v1.9 track.

If its getting delayed we can update and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: proposal Proposals and design documents
Projects
None yet
Development

No branches or pull requests

2 participants