Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for zoom events #185

Closed
wants to merge 2 commits into from
Closed

Add support for zoom events #185

wants to merge 2 commits into from

Conversation

tuckergordon
Copy link

Closes #112

Adds a 'zoom' event that can be listened to with graphviz.on('zoom', ..).

For example,

.on('zoom', () => {
  console.log('graphviz zoomed with event:', d3.event);
});

@magjac
Copy link
Owner

magjac commented Jan 14, 2021

Thank you so much for this contribution. I would like to have a test case before merging it so that 100% coverage is maintained. If you could provide that, I would really appreciate it. Otherwise I will add one before merging it, but perhaps not in the very near future.

@magjac magjac mentioned this pull request Feb 5, 2022
Merged
@magjac
Copy link
Owner

magjac commented Feb 5, 2022

Merged as #216. Thanks @tuckergordon.

@magjac magjac closed this Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for zoom events
3 participants
@tuckergordon @magjac @tucker-gordon-bah