Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing LESS guards create duplicate CSS #325

Open
friendscottn opened this issue Jan 11, 2023 · 6 comments · May be fixed by #326
Open

Missing LESS guards create duplicate CSS #325

friendscottn opened this issue Jan 11, 2023 · 6 comments · May be fixed by #326
Assignees
Projects

Comments

@friendscottn
Copy link

friendscottn commented Jan 11, 2023

Preconditions (*)

  1. Magento 2.4.5-p1 (not that this matters much)

Steps to reproduce (*)

  1. Compile the less files into CSS

Expected result (*)

  1. CSS should not be duplicated in styles-m.css and styles-l.css
  2. CSS should be only in one CSS file or the other. This affects css file size and performance.

Actual result (*)

  1. Several style rules are duplicated between the two files:
.form-discount .g-recaptcha {
  margin-top: 50px !important;
}
...
.login-container .g-recaptcha,
.form-login .g-recaptcha,
.form-edit-account .g-recaptcha {
  margin-bottom: 10px !important;
}
...
.required-captcha.checkbox {
  position: absolute;
  display: block;
  visibility: visible;
  overflow: hidden;
  opacity: 0;
  width: 1px;
  height: 1px;
}
...
.block.newsletter .field-recaptcha .field .control:before {
  content: none;
}
...
.review-form .field-recaptcha {
  margin-bottom: 10px;
}
@m2-assistant
Copy link

m2-assistant bot commented Jan 11, 2023

Hi @friendscottn. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


@m2-community-project m2-community-project bot added this to Ready for Grooming in Backlog Jan 11, 2023
@friendscottn friendscottn linked a pull request Jan 11, 2023 that will close this issue
5 tasks
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Backlog Jan 11, 2023
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Grooming in Backlog Jan 11, 2023
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Backlog Jan 11, 2023
@friendscottn
Copy link
Author

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Jan 11, 2023

Hi @friendscottn! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@friendscottn
Copy link
Author

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Jan 11, 2023

Hi @friendscottn! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@friendscottn
Copy link
Author

@magento add to contributors team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

1 participant