Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Customer signin_token purged on refresh #4152

Open
2 of 8 tasks
qburst-arjunsreedhar opened this issue Aug 9, 2023 · 6 comments
Open
2 of 8 tasks

[bug]: Customer signin_token purged on refresh #4152

qburst-arjunsreedhar opened this issue Aug 9, 2023 · 6 comments
Assignees
Labels
bug Something isn't working issue: Cannot Reproduce when issue not reproducible by internal team they might required additional info or steps missing Issue: Needs Update Additional information is require, waiting for response triage-done

Comments

@qburst-arjunsreedhar
Copy link

Describe the bug

A clear and concise description of what the bug is.

To reproduce

Steps to reproduce the behavior:

  1. Login as a customer in PWA store
  2. Set the token in storage using the BrowserPersistence util with key 'signin_token'.
  3. Refresh the page

Expected behavior

The token should be retained in the localStorage but it is purged.

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]: All devices
  • Browser [e.g. Chrome, Safari]: All Browsers
  • Browser Version [e.g. 22]:
  • Magento Version [e.g Adobe Commerce 2.4]: Magento ver. 2.4.6

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@qburst-arjunsreedhar qburst-arjunsreedhar added the bug Something isn't working label Aug 9, 2023
@m2-assistant
Copy link

m2-assistant bot commented Aug 9, 2023

Hi @qburst-arjunsreedhar. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

@RaghavendraTirumalasetti
Copy link
Contributor

Hi @qburst-arjunsreedhar,
As per testing, we are not able to reproduce the issue with the latest pwa local instance and also https://venia.magento.com/.

PFA for the screenshot:
Screenshot 2023-08-28 at 7 47 19 PM

@RaghavendraTirumalasetti RaghavendraTirumalasetti added issue: Cannot Reproduce when issue not reproducible by internal team they might required additional info or steps missing Issue: Needs Update Additional information is require, waiting for response labels Aug 28, 2023
@qburst-arjunsreedhar
Copy link
Author

Hey @RaghavendraTirumalasetti,

I was able to fix this issue by calling the handleSubmit function returned by the useSignIn talon but if I do not use this method and directly insert the token to localStorage this issue occurs.

@glo82145
Copy link
Collaborator

glo82145 commented May 9, 2024

@adobe export issue to Jira project PWA

@glo82145
Copy link
Collaborator

glo82145 commented May 9, 2024

@adobe export issue to Jira project PWA

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3278 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working issue: Cannot Reproduce when issue not reproducible by internal team they might required additional info or steps missing Issue: Needs Update Additional information is require, waiting for response triage-done
Projects
None yet
Development

No branches or pull requests

5 participants