Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop page id from result #38667

Open
wants to merge 16 commits into
base: 2.4-develop
Choose a base branch
from
Open

Drop page id from result #38667

wants to merge 16 commits into from

Conversation

thomas-kl1
Copy link
Member

Description (*)

Given the unit test: \Magento\Cms\Test\Unit\Model\GetUtilityPageIdentifiersTest::testExecute

Expected result is a list of identifiers.
Currently, if we set the following settings from BO:

  • web/default/cms_home_page
  • web/default/cms_no_route
  • web/default/cms_no_cookies

The format saved in the config is: |<page_id>

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#38666

Manual testing scenarios (*)

  1. 2 websites (a & b) with a specific home page configured for each (e.g: home-a for global, and home-b for website b)
  2. Create a sitemap for each websites
  3. Generate the sitemap from the admin grid

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 26, 2024

Hi @thomas-kl1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Dn’D partners-contribution Pull Request is created by Magento Partner labels Apr 26, 2024
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Apr 26, 2024
@thomas-kl1
Copy link
Member Author

@magento run Unit Tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 30, 2024
@thomas-kl1
Copy link
Member Author

thomas-kl1 commented Apr 30, 2024 •
edited

In continuity to 0ce7599

My requested changes still makes sense because the expected behavior of the service is to return a list of identifiers from the current scope.

I'm going to update the PR to align changes.

@thomas-kl1
Copy link
Member Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Partner: Dn’D partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Pull Requests Dashboard
  
Pending Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMS Pages used in settings are not excluded from sitemap
3 participants
@thomas-kl1 @engcom-Hotel @m2-github-services