Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38659 - Fix order status update #38661

Draft
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

Nuranto
Copy link
Contributor

@Nuranto Nuranto commented Apr 25, 2024

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Issue] Cannot update Order status in 2.4.7 #38659

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Apr 25, 2024

Hi @Nuranto. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@Nuranto
Copy link
Contributor Author

Nuranto commented Apr 25, 2024

@magento run all tests

@pbrouwers
Copy link

@Nuranto can you include a revert of the broken code here? 632f253

@Nuranto
Copy link
Contributor Author

Nuranto commented Apr 26, 2024

Actually, looking at this code, I wonder if we shouldn't take the opportunity to do a more thorough refactoring. This PR is a conveninent quick fix for the issue, but there's more to do :

The AddComment controller should use the OrderService::addComment service, and the state/status check that I added here should be done in the Order::addStatusHistory class. We will then need to revise the tests accordingly....

It's a too big task for me, especially without being sure that the PR will be approved, I think it would be worth asking for the opinion of the Magento architects.

What do you think ?

@Nuranto Nuranto marked this pull request as draft April 26, 2024 11:27
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Pull Requests Dashboard
  
Pending Review
Development

Successfully merging this pull request may close these issues.

[Issue] Cannot update Order status in 2.4.7
2 participants