Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Only deny customer access to order if it actually exists #38650

Open
2 of 5 tasks
m2-assistant bot opened this issue Apr 23, 2024 · 2 comments · May be fixed by #38647
Open
2 of 5 tasks

[Issue] Only deny customer access to order if it actually exists #38650

m2-assistant bot opened this issue Apr 23, 2024 · 2 comments · May be fixed by #38647
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2024

This issue is automatically created based on existing pull request: #38647: Only deny customer access to order if it actually exists


Description (*)

This allows loading nonexistent orders by customer.
Before: loading an empty order as a customer would trigger this check resulting in "No such entity with orderId = ", as there is no orderId yet since it doesn't exist yet.
Which means the order should be allowed.

After: Loading an empty order results in the empty order being returned, if it is a preexisting order the old checks apply

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Apr 23, 2024 that will close this issue
6 tasks
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Apr 23, 2024
@m2-community-project m2-community-project bot added Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. labels Apr 23, 2024
@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Apr 23, 2024
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Apr 23, 2024
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Apr 23, 2024
@engcom-November engcom-November self-assigned this May 10, 2024
Copy link
Author

m2-assistant bot commented May 10, 2024

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link

Hello @indykoning,

Thank you for the report and collaboration!

Could you elaborate the issue and also let us know the impact of the issue, steps to reproduce and use case.

@engcom-November engcom-November added the Issue: needs update Additional information is require, waiting for response label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Low Priority Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

2 participants