Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed replacing two dots with empty string in media file names on media cache generation #38645

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Removed replacing two dots with empty string in media file names on media cache generation #38645

wants to merge 1 commit into from

Conversation

dudzio12
Copy link
Member

Description (*)

This change removes replacing two dots with empty string. I have no clue why this was implemented, but if it's needed in some specific file storage setting then we should check for that specific situation before removing dots. Since I'm not aware about those scenarios for now, I suggest removing it completely.

In my case the problem occured with file like "test.....media.....file.jpg", which was replaced with "test.media.file.jpg".

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Thumbnails for media files containing two dots in name are not generated #38641

Manual testing scenarios (*)

  1. Upload image with name containing two dots to product media gallery
  2. Thumbnails and media cache should be generated

Questions or comments

  1. Is there any specific file storage setting where two dots should be removed?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 22, 2024

Hi @dudzio12. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Apr 22, 2024
@dudzio12
Copy link
Member Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor

I think that was security fix for paths like ../../../../some-file

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Apr 23, 2024
@dudzio12
Copy link
Member Author

I think that was security fix for paths like ../../../../some-file

That might be the case. Perhaps we could replace dots in path, but not in the basename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
Pull Requests Dashboard
  
Pending Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thumbnails for media files containing two dots in name are not generated
2 participants
@dudzio12 @ihor-sviziev