Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User is not redirected when use_store is enabled and path is empty #38616

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

User is not redirected when use_store is enabled and path is empty #38616

wants to merge 1 commit into from

Conversation

thomas-kl1
Copy link
Member

@thomas-kl1 thomas-kl1 commented Apr 12, 2024 •
edited by m2-assistant bot

Description (*)

When the setting use store code in url is enabled, and the setting redirect to base url is enabled, the end-user is not redirected to base url with store code in path if the request url has an empty path. It's because in the store::baseUrl method, the web type doesn't add the store code, while link type does.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] User is not redirected when use_store is enabled and path is empty #38625: User is not redirected when use_store is enabled and path is empty

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 12, 2024

Hi @thomas-kl1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Dn’D partners-contribution Pull Request is created by Magento Partner labels Apr 12, 2024
@thomas-kl1 thomas-kl1 mentioned this pull request Apr 12, 2024
Open
@thomas-kl1
Copy link
Member Author

@magento run all tests

@thomas-kl1
Copy link
Member Author

Errors in the test suite are not related to this PR changes

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Apr 16, 2024
Open
5 tasks
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Apr 16, 2024
@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Partner: Dn’D partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
Pull Requests Dashboard
  
Pending Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] User is not redirected when use_store is enabled and path is empty
3 participants
@thomas-kl1 @engcom-Hotel @m2-github-services