Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatiblity for constructor property promotions #70

Open
leonhelmus opened this issue Mar 8, 2023 · 1 comment
Open

Add compatiblity for constructor property promotions #70

leonhelmus opened this issue Mar 8, 2023 · 1 comment

Comments

@leonhelmus
Copy link

Add the moment i'm busy with adding constructor promotion properties to Magento Open Source, see:
magento/magento2#37032
magento/magento2#37037
magento/magento2#37040
and 20 others.

But i'm having the following issue at the moment:
See the code of this Pull Request: magento/magento2#37038
image
See the code of this Pull Request: magento/magento2#37037
image

It looks like in some cases it does not recognize some of the property promotions that i've used.

To me it looks like it's not supported. Could someone help me resolve this issue?

@m2-assistant
Copy link

m2-assistant bot commented Mar 8, 2023

Hi @leonhelmus. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Ready for Grooming
Development

No branches or pull requests

1 participant