Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer mode workflow #318

Open
drpayyne opened this issue May 5, 2021 · 3 comments
Open

Developer mode workflow #318

drpayyne opened this issue May 5, 2021 · 3 comments

Comments

@drpayyne
Copy link
Contributor

drpayyne commented May 5, 2021

Preconditions

  1. Use Magento Cloud Docker in developer mode

Steps to reproduce

  1. Follow steps in https://devdocs.magento.com/cloud/docker/docker-mode-developer.html to use cloud-docker in dev mode

Expected result

  1. Developers shouldn't have to run docker-compose run --rm deploy magento-command deploy:mode:set developer every time after cloud-deploy when docker-compose file was generated for developer mode. This sets the flag MAGE_MODE=developer. This should be used in cloud-deploy scenario to set the mode as developer instead of production, if present. I don't understand why we can't use that flag to set the deploy mode. Or another flag in probably .docker/config.env, in case the MAGE_MODE flag is meant only for the docker containers.

Actual result

  1. We have to set the deploy:mode to developer after every run of cloud deploy even if build:compose was run with developer flag since cloud-deploy always sets mode to production no matter the environment mode. During development, this seems unnecessary.
@drpayyne
Copy link
Contributor Author

drpayyne commented May 5, 2021

Yes, this isn't as simple as fixing the scenario to use the MAGE_MODE flag since this has implications on processes like setup:di:compile and setup:static-content:deploy.

@shiftedreality
Copy link
Member

We probably can add a new command/flag to https://github.com/magento/magento-cloud-docker/blob/develop/dist/bin/magento-docker and switch this after successful deployment.

Volunteer needed

@shiftedreality shiftedreality added community PR/issue origin feature request issue type help wanted issue allocation labels May 25, 2021
@shiftedreality
Copy link
Member

Internal issue: https://jira.corp.magento.com/browse/MCLOUD-7991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
Ready for Grooming
Development

No branches or pull requests

2 participants