Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Speed control #127

Open
dawsbot opened this issue Feb 27, 2017 · 3 comments
Open

[feature request] Speed control #127

dawsbot opened this issue Feb 27, 2017 · 3 comments

Comments

@dawsbot
Copy link

dawsbot commented Feb 27, 2017

After searching through the docs and source code both, I don't see any video speed controls. Is that something supported already and if not, is it something welcome in a PR?

There is var pbrateSlider = $('#controls-pbrate-slider')[0] in the source, but I don't see any slider in the actual application. I'm playing an mp4 on MacOS Sierra v10.12.3.

Possibly related: https://github.com/mafintosh/playback/pull/120/files#diff-168726dbe96b3ce427e7fedce31bb0bcR723

@phated
Copy link
Contributor

phated commented Feb 27, 2017

I believe I implemented this but there hasn't been a new release in awhile. If so, you can get it by making a custom build.

@dawsbot
Copy link
Author

dawsbot commented Feb 28, 2017

@mafintosh @phated would cutting a new release be possible instead? It seems like a useful feature that other people could also benefit from.

@phated
Copy link
Contributor

phated commented Feb 28, 2017

I'm not a project owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants