Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate file format #114

Open
ppeczek opened this issue Jun 14, 2016 · 5 comments
Open

Validate file format #114

ppeczek opened this issue Jun 14, 2016 · 5 comments

Comments

@ppeczek
Copy link

ppeczek commented Jun 14, 2016

Right now, you can load any kind of files: documents, images etc. Playback then doesn't display them and stops at black frame. This behaviour looks like playback was suspended. Really needs file format validation!

screenshot from 2016-06-14 12 50 30
screenshot from 2016-06-14 12 57 34

@freeall
Copy link
Collaborator

freeall commented Jun 14, 2016

That's a good idea. Is it something you would want to try to do @ppeczek?

@ppeczek
Copy link
Author

ppeczek commented Jun 14, 2016

Yes, but let's talk about it. My idea is quite naive: textfile with list of
supported extensions, splitting filename by ".", checking if extension is
supported
14 cze 2016 13:01 "Tobias Baunbæk" notifications@github.com napisał(a):

That's a good idea. Is it something you would want to try to do @ppeczek
https://github.com/ppeczek?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#114 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACy8fuwQBTjCDbEaRAgXVopUiVa4DvVzks5qLooOgaJpZM4I1Mwi
.

@mafintosh
Copy link
Owner

a module that does this would be cool (if it doesn't already exist)

@ppeczek
Copy link
Author

ppeczek commented Jun 14, 2016

Ok then, give me few hours and I will take care of this matter.

@ppeczek
Copy link
Author

ppeczek commented Jun 14, 2016

https://github.com/electron/electron/blob/master/docs/api/dialog.md
I found it but just for dialog. It has nothing to do with validation. I've already written part of code for extensions. I have to do sanitizer and we're home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants