Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim Script and Vim script should be combined #115

Open
louwers opened this issue Feb 20, 2024 · 5 comments
Open

Vim Script and Vim script should be combined #115

louwers opened this issue Feb 20, 2024 · 5 comments
Assignees
Labels

Comments

@louwers
Copy link

louwers commented Feb 20, 2024

No description provided.

@madnight madnight added the bug label Feb 23, 2024
@madnight madnight self-assigned this Feb 23, 2024
@madnight
Copy link
Owner

I see, thanks for reporting, will be fixed soon.

@madnight
Copy link
Owner

madnight commented Mar 1, 2024

I added a fix that filters the lowercase "Vim script" and leaves "Vim Script." I think "Vim Script" is the official name on GitHub, and I'm not sure why there is also a lowercase variant in the GitHub BigQuery Dataset. Currently, I do not have enough credits/dollars left to rerun the entire history with a proper merge in SQL. Therefore, I filtered out the lowercase naming, which also has a significantly lower count of events.

@louwers
Copy link
Author

louwers commented Mar 2, 2024

The official name is "Vim script" as per the manual.

image

And Wikipedia: https://en.wikipedia.org/wiki/Vim_(text_editor)#Vim_script

If you ever do a re-run, I would change it to that.

I would not filter out "Vim script", because this results in an inaccurate comparison of languages. Having a duplicate is preferable to this in my opinion.

@madnight
Copy link
Owner

madnight commented Mar 2, 2024

You are right, but I referred to the "official name on GitHub". For instance if you open one of the most popular Vim script projects on GitHub and look at the language name https://github.com/tpope/vim-fugitive it will read "Vim Script".

@louwers
Copy link
Author

louwers commented Mar 2, 2024

Ah right, so maybe we should file a bug report with GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants