Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celsius as Temperature Unit #7

Closed
popoway opened this issue Nov 25, 2020 · 7 comments
Closed

Celsius as Temperature Unit #7

popoway opened this issue Nov 25, 2020 · 7 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@popoway
Copy link

popoway commented Nov 25, 2020

Currently the app shows CPU temperature in Fahrenheit. It might be helpful to have an option to switch between Fahrenheit and Celsius unit to fit the needs of users from various countries. Thanks!

@macmade
Copy link
Owner

macmade commented Nov 25, 2020

The reported temperature should already be in Celsius.
What values are you reading?

@popoway
Copy link
Author

popoway commented Nov 25, 2020

I was reading something above 130º when I initially opened the app. I restarted the app and now it shows 45º, so that's confusing. I am running Hot 1.2.2(42) on macOS 11.1 Beta (20C5048k).

@macmade
Copy link
Owner

macmade commented Nov 25, 2020

I never encountered this behavior. Can you reproduce the issue?
If not this will be hard to understand what's going on...

@rogelin
Copy link

rogelin commented Nov 25, 2020

Hi,
Thanks for this amazing work.
I guess @popoway is referring to this place where should be showing the Unity (in this case Celcius) besides de value.
image

@macmade macmade self-assigned this Nov 25, 2020
@macmade macmade added the help wanted Extra attention is needed label Nov 25, 2020
@macmade
Copy link
Owner

macmade commented Nov 26, 2020

Thanks, I'll add an option in the preference to display the temperature in Celsius or Fahrenheit and display the unit in the list.

@shepazon
Copy link

shepazon commented Nov 27, 2020

I just committed this PR that adds Fahrenheit support as a toggleable option.

@macmade
Copy link
Owner

macmade commented Nov 28, 2020

Thanks a lot @shepazon. Your PR was just merged. : )
Marking the issue as closed.

@macmade macmade closed this as completed Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants