We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hey Maciej,
thanks a lot for the whole course and your work.
I have spotted a small issue. When I've downloaded your project background of the project was black, while I expected a violet one. Nevertheless, default implementation still suggests a violet as a variable name: https://github.com/maciejkorsan/wtf-gulp-starter/blob/master/src/scss/_variables.scss#L1
I'm aware, that issue is really minor, but on the other hand, it can be misleading, especially for the newcomers.
I can open a PR with a fix, but just I'm not sure if the variable should be named black, or color should be adjusted.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hey Maciej,
thanks a lot for the whole course and your work.
I have spotted a small issue. When I've downloaded your project background of the project was black, while I expected a violet one. Nevertheless, default implementation still suggests a violet as a variable name:
https://github.com/maciejkorsan/wtf-gulp-starter/blob/master/src/scss/_variables.scss#L1
I'm aware, that issue is really minor, but on the other hand, it can be misleading, especially for the newcomers.
I can open a PR with a fix, but just I'm not sure if the variable should be named black, or color should be adjusted.
The text was updated successfully, but these errors were encountered: