Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boot2Docker ISO file always downloaded #197

Open
ggrussenmeyer opened this issue Sep 1, 2017 · 0 comments
Open

Boot2Docker ISO file always downloaded #197

ggrussenmeyer opened this issue Sep 1, 2017 · 0 comments

Comments

@ggrussenmeyer
Copy link

Symptom

Whenever a new machine is created, the Boot2Docker ISO is downloaded, even the newest one has been cached (cf. docker/machine#4058).

Root cause

Only the 3 digits of the version number are considered when extracted from the ISO:
https://github.com/zchee/docker-machine-driver-xhyve/blob/a2060c0729fc92f98265d85bdaed6dd88562bf15/b2d/b2d.go#L219
while the actual (and encoded) version number may be suffixed (e.g. with "-ce" in v17.07.0-ce ISO file version).
Thus for the v17.07.0-ce ISO file, the version is parsed as 17.07.0 while the advertised one (in https://api.github.com/repos/boot2docker/boot2docker/releases/latest) is 17.07.0-ce, hence a mismatch and hence a download.

It is weird that the docker-machine source code implementation for that extraction, which differs, is broken as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant