add image comparison to diff viewer

[antis81]

This one is about merging this:
https://github.com/claus007/ImageComparerLibrary

@claus007 I'd fork it into the @macgitver group and setup a PR for that. Ok?

Then the real work begins:

• Setup the cmake file for the lib
• Check and unify API against https://github.com/macgitver/libDiffViews
• Add the visualization part

[scunz]

Are we sure this can be abstracted in a way that it makes sense for others to use it outside of libDiffViews or outside of MGV? If no, we could for the sake of simplicity as well move the files into a subdirectory in libDiffViews.

[claus007]

Am Samstag, den 03.08.2013, 01:57 -0700 schrieb Nils Fenner:

@claus007 I'd fork it into the @macgitver group and setup a PR for
that. Ok?

what is a pr ?

[scunz]

@claus007, on GitHub, a "Pull Request" (PR) is more or less a discussion on a "branch to integrate".

The basic workflow is like:

1. create a branch with some commits inside and push it to GitHub.
2. create a pull request. By doing this, you specify where the branch should be merged.
3. GitHub creates the PR. It is actually just an "Issue" like this one; but the code is attached to it and it can be commented, reviewed and discussed in whatever way is necessary to make all parties happy.
4. Someone clicks the "merge" button; GitHub will do all the required work to merge the branch into its target.

[claus007]

ok well I am new to this stuff....

If no, we could for the sake of simplicity as well move the files into a subdirectory in libDiffViews.

this sounds better to me - if I understood the pull request thing right

and I want to state out that the library interface should stay as it is. (minimal but complete)
can't you just take it as submodule ?
if so do I also have to make pr's ?

[scunz]

We could as well use it as a submodule. But the build systems need to match. MacGitver uses CMake.

Further, there is a lot of work to do inside our diff views themselves. I think @antis81 talked about that either.

[claus007]

Am Samstag, den 03.08.2013, 08:39 -0700 schrieb Sascha Cunz:

We could as well use it as a submodule. But the build systems need to
match. MacGitver uses CMake.

good point - thought of this also ....
can you do tell cmake something like include theses cpp-files in this
subdir from a parent directory ? and just ignore the pro-file ?
(would make my life also easier)

[scunz]

We will if we need, but we won't if we don't :)