Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poco-Source #54

Open
OgreTransporter opened this issue Apr 16, 2017 · 6 comments
Open

Poco-Source #54

OgreTransporter opened this issue Apr 16, 2017 · 6 comments

Comments

@OgreTransporter
Copy link

I'm wondering that there is a copy of the poco libraries in this project. I think it's better to include poco as a git sub module, because in this case bugfixes from poco are also available for macchina.io. The mirai bot net used insecure IoT devices so it's neccesary to update macchina.io as fast as possible after a bugfix has been submitted to poco.

@uilianries
Copy link
Contributor

Hi!
I'm using conan.io to solve my project dependencies, including Poco.
Machinna.io could use Conan to include Poco as dependency, instead copy whole project.

@OgreTransporter
Copy link
Author

Hi!

Nice idea, but conan.io is not necessary, because you could use poco as a git sub module. This includes the poco source code on git clone/fetch/pull.

@aleks-f
Copy link
Member

aleks-f commented May 11, 2018

git submodule is proper solution; however, it requires buildsystem changes because poco libraries are now spread directly under platform directory. OSP should also be moved into separate repository and included as submodule, see #15

I'm thinking probably the cleanest solution would be POCO and OSP in separate submodules, the rest either directly under platform or moved to the submodules if it makes sense.

if anyone wants to tackle this, go for it, see also #53

conan is a separate concern from this

@obiltschnig
Copy link
Member

Before anyone starts doing some work regarding this - please coordinate with me first.

@OgreTransporter
Copy link
Author

I agree, changing the build system to CMake (#53) is a necessary requirement. With CMake it is also easy to integrate the build scripts from submodules into the build system of the main project. E. g. this means that the CMake script "platform" can build Poco and OSP as submodules. It is not necessary to carry (possibly outdated) dependencies with you.

But where to start? First switch to CMake and then outsource OSP? Or outsource OSP first and then switch to CMake?

@obiltschnig
Copy link
Member

Switch to (add support for) CMake to macchina.io first. This is already planned for July for a customer project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants