Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt 6.7 added a Windows 11 theme, which enabled dark mode, and this makes the icons hard to see in mcrl2ide #1762

Open
mlaveaux opened this issue Apr 9, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@mlaveaux
Copy link
Member

mlaveaux commented Apr 9, 2024

This is mCRL2ide compiled with Qt 6.7. Although the icons are also the same for macOS dark mode it seems to me like the background is darker, thus making it hard to see them.

image

Whereas the nightly version, using Qt 6.6, looks fine:

image

@mlaveaux mlaveaux added the bug Something isn't working label Apr 9, 2024
@krab
Copy link

krab commented May 4, 2024

Yep they added dark mode but still there is no simple way to detect these changes.
https://github.com/search?q=repo%3Aqt%2Fqtbase%20colorSchemeChanged&type=code
Their signal colorSchemeChanged never emits by Qt developers, none QPA plugins emits it if I understand correctly.

@mlaveaux
Copy link
Member Author

Currently, we do not have suitable icons for the Windows dark mode palette. So my proposed solution would be to set windows:darkmode=0 on startup to disable dark mode on Windows completely for the time being.

@mlaveaux mlaveaux self-assigned this May 21, 2024
@Valo13
Copy link
Member

Valo13 commented May 21, 2024

I could make some icons suitable for light mode. Concerning detection of dark mode, I can remember adding basic code for that, for instance for the text editor syntax colouring, that simply checks whether the background is dark and if so, uses dark mode defaults. I guess the same thing can be done here.

@mlaveaux
Copy link
Member Author

If you want to make icons for light than that could work as well for mcrl2ide. Perhaps for ltsgraph it might still be useful to disable dark mode due to the white canvas. Also my proposed solution does not work for the menus for whatever reason.

image

@mlaveaux mlaveaux added this to the release 202406 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants