Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The selection is Diagraphica's edit mode is broken #1720

Closed
FerryT opened this issue Oct 5, 2023 · 4 comments
Closed

The selection is Diagraphica's edit mode is broken #1720

FerryT opened this issue Oct 5, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@FerryT
Copy link
Collaborator

FerryT commented Oct 5, 2023

While testing the Qt6 build (feature/qt6) under windows (MSVC) I came across a few issues.

  1. In ltsview, changing the "accuracy" of the diagram causes it to crash.
  2. In Diagraphica, in edit mode, selections do not work anymore.
    I will update this list when I find more.
@FerryT FerryT added the bug Something isn't working label Oct 5, 2023
@mlaveaux mlaveaux self-assigned this Oct 5, 2023
@mlaveaux
Copy link
Member

Changing the "accuracy" in ltsview yields some kind of OpenGL crash, which is hard to debug since this tool is still using the compatibility mode. Not sure why switching to Qt6 has an influence on this yet, maybe something changed about the way that OpenGL is initialised in Qt.

@mlaveaux
Copy link
Member

I have removed the accuracy option since I cannot fix this anyway. It might be worth to refactor the ltsview drawing at some point anyway.

@mlaveaux mlaveaux changed the title Qt6 bugs The selection is Diagraphica's edit mode is broken Mar 7, 2024
@mlaveaux
Copy link
Member

mlaveaux commented Mar 7, 2024

The only remaining issue found so far is the one pertaining Diagraphica, so repurposed this issue to keep track of that issue.

@mlaveaux mlaveaux added this to the release 202406 milestone Mar 7, 2024
@mlaveaux
Copy link
Member

This issue has been fixed by @FerryT as well as other subtle bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants