Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'll donate to whoever can make phone layout exactly like it is on caracal.club #381

Open
SpiderSuave opened this issue Mar 26, 2024 · 14 comments
Labels
help wanted Extra attention is needed sponsored Sponsored feature requests / bugfixes

Comments

@SpiderSuave
Copy link

Hello and my apologies in advance if this sounds a little off but this is my serious offer.

I am a movie buff and I've fallen in love with Neko as my go-to app for watchparties, and I'm hoping there's just one little thing that can be done to it for the benefit of phone users.

Every month, a group of us get together for a watchparty and it's all beautiful for desktop/laptop users, but for the few phone users who show up, it's always a problem.

Before Neko I was using caracal.club which has the ideal phone layout that I was hoping could be done to Neko. It simply involves the phone in landscape mode showing the display in full screen, where the user can scroll up to bring up the chatroom below it and scroll down again to continue watching the display. On caracal.club you can see exactly how this works by just quickly entering one of their public rooms with your phone with no signup required.

To whoever can do a mod to add that as an optional layout for phone users, I can send an Amazon gift card code worth $50.

Thanks again for a wonderful app and again sorry if this sounds a little off but this is something I REALLY want and would much appreciate if it can be done. Thank you for your hard work and peace to all.

@m1k1o m1k1o added the help wanted Extra attention is needed label Mar 26, 2024
@m1k1o
Copy link
Owner

m1k1o commented Mar 27, 2024

That layout seems to be really convenient for movie nights, I agree. You seem to motivated me succesfully, I'll take a look if it could be done somehow easily. But anyone who would like to take this and implement, they should feel free to do so.

@m1k1o m1k1o added the sponsored Sponsored feature requests / bugfixes label Mar 27, 2024
@SpiderSuave
Copy link
Author

That layout seems to be really convenient for movie nights, I agree. You seem to motivated me succesfully, I'll take a look if it could be done somehow easily. But anyone who would like to take this and implement, they should feel free to do so.

Thank you. That would be amazing if you could do this since this project is your baby, and yes that layout really is the ideal for phone users. While watching movies in a group, even if it's just one person out of 20 who is on phone and having trouble, it kind of spoils it for the rest of the group since we're all friends, hence why I would so much love to see this implemented in Neko.

As stated, just like caracal.club has it would be awesome. The ideal would be for landscape mode to cause the phone to go in true full screen without any browser border or address bar eating up display area, just like if the user had pressed the full screen button while in landscape, but then while in that full screen be able to swipe up anywhere in the display to bring up the full screen chatroom below to see messages and type and swipe down again to bring down the full screen movie.

Thanks again and much appreciated.

@SpiderSuave
Copy link
Author

Any chance it can be done before Saturday? If not, no worries and whenever it's possible is much appreciated. I'm just wondering since I'm having the next watchparty this weekend. Thanks again.

@m1k1o
Copy link
Owner

m1k1o commented Apr 2, 2024

@SpiderSuave i don't think we can get it merged to the master that fast, but i created some quick proof of concept. You could checkout to scroll-to-chat-on-mobile branch, and build client for yourself. Is that something you had in mind?

Build instructions:

git clone https://github.com/m1k1o/neko
cd neko/.docker
git checkout scroll-to-chat-on-mobile
./build base
./build firefox

Now you can test your local m1k1o/neko:firefox image.

@SpiderSuave
Copy link
Author

Hi. I'm trying to test it and the build finished fine with no problem, using xfce instead of firefox. How can I pull the local xfce image using Neko Rooms instead of it grabbing the one from the Internet? Sorry I'm a bit lost here. Thank you for any help.

@m1k1o
Copy link
Owner

m1k1o commented Apr 3, 2024

You can build it directly on the server where neko rooms is and then it will use that image.

Or you can use ssh to copy your image to the server. https://stackoverflow.com/a/23938978

@SpiderSuave
Copy link
Author

SpiderSuave commented Apr 3, 2024

You can build it directly on the server where neko rooms is and then it will use that image.

Or you can use ssh to copy your image to the server. https://stackoverflow.com/a/23938978

Thank you. It now works. The problem was I was building the image first before running the neko-rooms install script which would then untag the image.

This is a huge improvement for phone layout. Please let me know how I can private message you the Amazon gift card code.

A few fixes if possible please:

In Chrome, the browser address bar stays displayed the entire time covering valuable screen space. It would be nice if it would autohide or just not appear. On Firefox though it autohides.

Swiping up/down only works on the edges of the screen outside the display or anywhere in the chatroom, but it works anywhere on the screen after login before the audio symbol is tapped to turn on the display. It would be great if swipe works from anywhere in the display.

Even when the controls are locked, phone users can still click the button to request controls which shows the admin a request message. This is a bug that has always existed in phone layout.

The hamburger button should be removed from this phone layout since all it does is just lock the chatroom.

Below the chatroom it should show avatars of users in the room.

Thanks again for your work.

@m1k1o
Copy link
Owner

m1k1o commented Apr 4, 2024

Please let me know how I can private message you

You can join neko discord server.

In Chrome, the browser address bar stays displayed the entire time covering valuable screen space. It would be nice if it would autohide or just not appear. On Firefox though it autohides.

Not sure how that could be done. By entering full screen maybe? But i am testing on iOS on Safari and they don't allow custom element entering fullscreen only video element.

Swiping up/down only works on the edges of the screen outside the display or anywhere in the chatroom, but it works anywhere on the screen after login before the audio symbol is tapped to turn on the display. It would be great if swipe works from anywhere in the display.

Fixed.

Even when the controls are locked, phone users can still click the button to request controls which shows the admin a request message. This is a bug that has always existed in phone layout.

Fixed.

The hamburger button should be removed from this phone layout since all it does is just lock the chatroom.

I cannot remove it now, because all changes that I make are CSS only, and what is shown on the screen is part of the javascript. If I would hide it from CSS, there could be a situation, where user has it closed and then he wont be able to see anything or change it on the mobile. So this needs to be fixes separately.

Below the chatroom it should show avatars of users in the room.

Same reason as above, logically its placed in the code before the chatroom so it would need to be somehow moved. CSS could not do this reliably without various hacks.

@SpiderSuave
Copy link
Author

Awesome! Thank you so much. I just sent you a DM on discord. Please confirm here that you got it and that it's safe to send you gift card code there. Thank you.

@m1k1o
Copy link
Owner

m1k1o commented Apr 5, 2024

Thanks! Yes I just accepted your DM on discord.

@SpiderSuave
Copy link
Author

Thank you. Claim code was sent. Please let me know you were able to redeem the gift card fine. Thanks again for your work on this app.

@m1k1o
Copy link
Owner

m1k1o commented Apr 5, 2024

Thank you for supporting the project @SpiderSuave.

@SpiderSuave
Copy link
Author

Hi. Just a little fix here if possible. When logging in through phone, the login prompt is out of view below the display, requiring the user to swipe up a bit to get it into view. Can this be fixed so login prompt is centered at login?

Note on address bar: I had incorrectly said it stays displayed the entire time but it actually autohides when the display is swiped up so that’s good. The problem is just that when a phone user is done chatting, they of course need to swipe down to bring the display into view and that’s what causes the browser bar to show, so they then need to swipe up a little to hide it. Maybe something to try could be an event simulating a swipe up to autohide the address bar?

Also just as a suggestion: Could both the original phone layout and this phone layout be selected as an option, maybe with a url parameter if that’s the easiest way to do it?

Phone layout now works nicely though so these are just additional things to try hopefully without ruining what’s there now.

Thanks again.

@m1k1o
Copy link
Owner

m1k1o commented Apr 15, 2024

Hi. Just a little fix here if possible. When logging in through phone, the login prompt is out of view below the display, requiring the user to swipe up a bit to get it into view. Can this be fixed so login prompt is centered at login?

Fixed.

Note on address bar: I had incorrectly said it stays displayed the entire time but it actually autohides when the display is swiped up so that’s good. The problem is just that when a phone user is done chatting, they of course need to swipe down to bring the display into view and that’s what causes the browser bar to show, so they then need to swipe up a little to hide it. Maybe something to try could be an event simulating a swipe up to autohide the address bar?

If that should be some SVG / CSS / GIF animation, we would need to find apropriate and display it when we know, that the address bar is shown. Not sure if that can be read from javascript, because it is shown anytime when user scrolls to top, I think.

Also just as a suggestion: Could both the original phone layout and this phone layout be selected as an option, maybe with a url parameter if that’s the easiest way to do it?

Would not be possible without moving the changes to JS. We cannot rely on screen size only but we would need to determine it from user agent, e.g. https://stackoverflow.com/a/73731646/1113204

It would also require client configuration from the server, which is yet missing.

m1k1o added a commit that referenced this issue Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed sponsored Sponsored feature requests / bugfixes
Projects
None yet
Development

No branches or pull requests

2 participants