Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please support Visual C ++ 6.0 #947

Open
ohyeah521 opened this issue Nov 9, 2020 · 8 comments
Open

please support Visual C ++ 6.0 #947

ohyeah521 opened this issue Nov 9, 2020 · 8 comments

Comments

@ohyeah521
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

please support Visual C ++ 6.0

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Cyan4973
Copy link
Member

Cyan4973 commented Nov 9, 2020

I don't have Visual C++ 6.0, and therefore can't make it happen all by myself.
The source code is supposed to be C90 compatible, and even embeds restrictions to be directly compatible with C++ too.
So this is a good start, but I can't guarantee that there aren't any specificity getting in the way.

I'm very likely to accept support on this topic.
Just, since VC6 is a pretty old and by now unsupported compiler, keep patches small and well localized.
Sprawling changes impacting maintenance complexity for the entire source code are not a good deal.

@ohyeah521
Copy link
Author

i like vc6, it's small and quik, this is vc6 without install ,just unzip and run init app "安装.exe" ,it can works on xp and win7, not test on win10.
https://onedrive.live.com/embed?cid=0FB627D302D4CE25&resid=FB627D302D4CE25%21972&authkey=AIGkwyx1tRk6Aws

@aqrit
Copy link
Contributor

aqrit commented Nov 14, 2020

lz4/lib/lz4.c

Line 536 in 26bc447

# if defined(_MSC_VER) && !defined(LZ4_FORCE_SW_BITCOUNT)

should probably be
# if defined(_MSC_VER) && (_MSC_VER >= 1400) && !defined(LZ4_FORCE_SW_BITCOUNT)

@ohyeah521 does this solve your issue?

@Cyan4973
Copy link
Member

It certainly wouldn't cost much to add !

Cyan4973 added a commit that referenced this issue Nov 14, 2020
@aqrit
Copy link
Contributor

aqrit commented Nov 14, 2020

also here

lz4/lib/lz4.c

Lines 124 to 125 in 26bc447

#ifdef _MSC_VER /* Visual Studio */
# include <intrin.h>

from https://rt.cpan.org/Public/Bug/Display.html?id=83876

Cyan4973 added a commit that referenced this issue Nov 15, 2020
only include <intrin.h> on vs2005+ (#947)
remove some useless #pragma
fix a few minor Visual warnings
Cyan4973 added a commit that referenced this issue Nov 15, 2020
only include <intrin.h> on vs2005+ (#947)
remove some useless #pragma
fix a few minor Visual warnings
@ohyeah521
Copy link
Author

if defined(_MSC_VER) && (_MSC_VER >= 1400) && !defined(LZ4_FORCE_SW_BITCOUNT)

no, vc6 had some errors

@hglee
Copy link

hglee commented Dec 24, 2020

I attached compiler error log by VC6.

But it seems hard to fix build errors.

From error log file, you can find

  • VC6 does not support unsigned long long. But unsigned __int64 allowed.
  • VC6 does not support unsigned long long literal suffix(ULL)
  • VC6 does not support variadic macro
  • VC6 does not support declspec deprecated

20201224_VC6_error.txt

@Neustradamus
Copy link

What is the situation of this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants