Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodeSelector does not get picked up #250

Open
sushraju opened this issue Mar 16, 2022 · 1 comment · May be fixed by #252
Open

nodeSelector does not get picked up #250

sushraju opened this issue Mar 16, 2022 · 1 comment · May be fixed by #252

Comments

@sushraju
Copy link

sushraju commented Mar 16, 2022 •
edited

We are trying to set the nodeSelector attribute in the taskManagerConfig and jobManagerConfig, but, it gets ignored.

jobManagerConfig:
    nodeSelector:
     instancezone: primary
    resources:
      requests:
        memory: "1Gi"
        cpu: "500m"
      limits:
        memory: "1Gi"
    envConfig:
...

Here's how it is being defined in the schema:

jobManagerConfig:
              type: object
              properties:
                replicas:
                  type: integer
                  minimum: 1
                offHeapMemoryFraction:
                  type: number
                  minimum: 0
                  maximum: 1
                systemMemoryFraction:
                  type: number
                  minimum: 0
                  maximum: 1
                nodeSelector:
                  type: object
                  properties:
                    additionalProperties:
                      type: string

taskManagerConfig:
              type: object
              properties:
                taskSlots:
                  type: integer
                  minimum: 1
                offHeapMemoryFraction:
                  type: number
                  minimum: 0
                  maximum: 1
                systemMemoryFraction:
                  type: number
                  minimum: 0
                  maximum: 1
                nodeSelector:
                  type: object
                  properties:
                    additionalProperties:
                      type: string
@sushraju
Copy link
Author

sushraju commented Mar 17, 2022 •
edited

So, in k8s 1.20 we added x-kubernetes-preserve-unknown-fields: true to the validation schema. That seems to help for now.

@skidder skidder linked a pull request Apr 28, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add x-kubernetes-preserve-unknown-fields to nodeSelector config. skidder/flinkk8soperator
1 participant
@sushraju