Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle AWS regional resource tags and improve performance #1137

Open
achantavy opened this issue Mar 14, 2023 · 1 comment
Open
Labels
AWS Related to cartography's AWS module bug Something isn't working performance Issues or feature requests related to performance

Comments

@achantavy
Copy link
Contributor

Description:

What issue is being seen? Describe what should be happening instead of the bug, for example: Cartography should not crash, the expected value isn't returned, the data schema is wrong, etc.

Some AWS resources have regions: RDS, DynamoDB, etc. Some don't: IAM policies, IAM roles, etc.

Asks:

  1. The resourcegroupstagging API optionally accepts a region. To avoid unnecessary AWS calls, we should only specify the region when the resource-tag being synced actually has a region.

  2. It is possible for a resource with the same name to have different regions, for example we can have an RDS instance with the same name but in us-east-1 and us-east-2. The tags for each of them can differ. When attaching the tag to the regional resource, we should match on the specific regional resource and then attach the tag. This ensures that the correct tag is applied to the correct regional resource.

@achantavy achantavy added bug Something isn't working performance Issues or feature requests related to performance labels Mar 14, 2023
@achantavy achantavy added the AWS Related to cartography's AWS module label Jul 14, 2023
@achantavy
Copy link
Contributor Author

achantavy commented Jul 14, 2023

Closely related to #1094 but not quite a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWS Related to cartography's AWS module bug Something isn't working performance Issues or feature requests related to performance
Projects
None yet
Development

No branches or pull requests

1 participant