Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pulldown-cmark #1412

Open
thomas-zahner opened this issue Apr 25, 2024 · 0 comments
Open

Update pulldown-cmark #1412

thomas-zahner opened this issue Apr 25, 2024 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@thomas-zahner
Copy link
Member

Updating to pulldown-cmark v0.10 introduces breaking changes. These affect how the library is used within lychee. Most notably:

  • HTML events seem to be emitted differently and/or require a feature to be enabled
  • Heading endings do no longer emit the ID of the heading

This was discovered and discussed in PR 1407. I tried to update the code accordingly, but didn't spend too much time on it and haven't had much success. My attempt can be found at update-cmark.
@thomas-zahner thomas-zahner added the dependencies Pull requests that update a dependency file label Apr 25, 2024
@thomas-zahner thomas-zahner mentioned this issue Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomas-zahner