Globs ignore exclude_path

[Wumpf]

I wanted lychee to check rust files, so I run lychee **/*.rs, confused why it takes so long to scan for links, I ran lychee **/*.rs --dump-inputs which showed that paths excluded via exclude_path options (e.g. target) did not influence the glob.

This is quite inconvenient since what I'm actually after is adding extensions to be checked. At the very least this should be documented better.

[mre]

I think it should actually should work, though.
At least that's the idea of this part:

lychee/lychee-lib/src/types/input.rs

Lines 337 to 338 in eb12064

	if self.is_excluded_path(&path) {
	continue;

At this point, I don't know why it doesn't work.
One note, though: you're using your operating system's glob handling. Glob expansion happens in your shell.
To use the Rust-based one, you need to quote the glob.

lychee '**/*.rs' --dump-inputs

so

lychee --exclude-path './target/' '**/*.rs' --dump-inputs

However, this gives me the same incorrect results as you described.
If you find the correct incantation, we should certainly document that.
Otherwise, I consider this a bug and would love to have someone investigate that.
Not sure if you have the time, but I'd certainly appreciate your help.

As a side note, glob filtering is not ideal right now. Would love to move to globset, which would allow us to provide multiple globs and so on. That shouldn't be a blocker for better exclude handling for globs with the current implementation, though.