Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing and CI #70

Open
ncrmro opened this issue Feb 17, 2017 · 4 comments
Open

Testing and CI #70

ncrmro opened this issue Feb 17, 2017 · 4 comments

Comments

@ncrmro
Copy link
Collaborator

ncrmro commented Feb 17, 2017

At the moment I have a project that whenever the repo get's pushed to has circle ci

  • build the project
  • tests graphql end point query works
  • uses selenium to
    • navigate to a few pages to make sure they load
    • test form validation errors such as sign up form
    • takes a picture which circle ci stores

I'd like to add some of this testing to this project.
I'm thinking the first pull request would simply be to get the project to build on ci.

Then go from there.

Browser Testing

  • mocha
  • Selenium

Unit Testing

  • Jest

CI Contentious Integration

  • circle ci
@ncrmro
Copy link
Collaborator Author

ncrmro commented Feb 17, 2017

This pull request has a pretty simple ci config to get things moving.

Let me know what guys thinks if you like the idea or not.

@lvarayut
Copy link
Owner

Totally agree with you! Testing and CI are the missing parts in Relay Fullstack.

@ncrmro
Copy link
Collaborator Author

ncrmro commented Mar 6, 2017

So I've been thinking the best way to incorporate tests into the canary branch before further investigating. Which should technically use yo to generate the project and test that rather than the branch?

@Neitsch
Copy link
Collaborator

Neitsch commented Mar 6, 2017

Master and canary don't use yo currently. Check out my PR to incorporate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants