Cannot be built from release tarball with default make options

[hasufell]

lua and luajit submodules are missing from the tarball: https://github.com/luvit/luv/tree/master/deps

Using system luajit doesn't work, because cmake checks are trying to access private headers, such as lj_arch.h. I have no idea why.

[squeek502]

Building from source should work with a release tarball (not the Source code ones, but the ones named like luv-1.30.1-1.tar.gz). Not much we can do about the Github zip not including submodules.

Are you using LUA_BUILD_TYPE=System when trying to build with system LuaJIT as described here?

[hasufell]

Building from source should work with a release tarball

Yes, I'm talking about the release tarball. I doesn't contain all submodules.

Are you using LUA_BUILD_TYPE=System when trying to build with system LuaJIT as described here?

Haven't tried that yet.

[squeek502]

Yes, I'm talking about the release tarball. I doesn't contain all submodules.

Whoops, you're right. That tarball really only exists for LuaRocks, which doesn't expect to need to compile Lua from source. For compiling everything from source, your best best would be to do a git clone. Is there a reason you want a tarball instead?

[hasufell]

Is there a reason you want a tarball instead?

Packaging. Using a git clone is suboptimal. The tarball should always have all submodules included.

[squeek502]

It's a bit harder of a call since this is a Lua module not tied to any specific Lua version. For packaging purposes, it should probably compile against whatever Lua version the user wants rather than compile LuaJIT from source, right?

Could you describe your use case a bit more? Are there other similar Lua projects you're working with that handle this sort of thing better?

[hasufell]

For packaging purposes, it should probably compile against whatever Lua version the user wants rather than compile LuaJIT from source, right?

I'm on a source distro. Either I compile against the system version (there is only one, which is Luajit-2.0.5) or I use the bundled one. I cannot use the bundled one, because it's not in the tarball. The user cannot choose any version.

Are you using LUA_BUILD_TYPE=System when trying to build with system LuaJIT as described here?

This works

[squeek502]

I think this might just be down to default make being more development oriented than end-user oriented (or legacy-oriented, since luv started out as specific to LuaJIT and not a general Lua module). I don't think we should provide a bundled Lua with release distributions because, for example, if we bundled Lua 5.3 (which we also have as a submodule) and that was compiled/used by default, then the result would fail if you tried to run it with your system's LuaJIT.

Maybe we should move to LUA_BUILD_TYPE=System as more of a default.