Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv.cancel #416

Open
SinisterRectus opened this issue Oct 15, 2019 · 3 comments
Open

uv.cancel #416

SinisterRectus opened this issue Oct 15, 2019 · 3 comments
Labels

Comments

@SinisterRectus
Copy link
Member

SinisterRectus commented Oct 15, 2019

Working on documenting uv_req_t in #409

According to libuv: uv_fs_t, uv_getaddrinfo_t, uv_getnameinfo_t and uv_work_t are cancellable.

However, uv_work_t is not cancellable in luv; uv.queue_work doesn't return any userdata. The request seems to be wrapped up in luv_work_t and/or luv_work_ctx_t.

Additionally, the req:cancel() method is not bound to any of the above request types.

@zhaozg
Copy link
Member

zhaozg commented Oct 16, 2019

Luv not expose uv_req_t to lua, should we consider about cancel

@SinisterRectus
Copy link
Member Author

The uv_req_t type is not exposed, but sub-types are.

@squeek502
Copy link
Member

req:cancel() added in #494. uv_work_t is still not cancellable, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants