Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dangling symbols #1191

Open
arthurpaulino opened this issue Mar 4, 2024 · 0 comments · May be fixed by #1195
Open

Avoid dangling symbols #1191

arthurpaulino opened this issue Mar 4, 2024 · 0 comments · May be fixed by #1195
Assignees
@arthurpaulino

Comments

@arthurpaulino
Copy link
Member

arthurpaulino commented Mar 4, 2024 •
edited

@porcuquine said;

[...] We should try to work toward a world where the default is for symbols to be interned.

In terms of engineering, this means that State and Package should be the (only?) ones instantiating (interning) symbols from paths.

#1189 points to the possibility that Lang should hold a map from SymbolRef (Arc<Symbol>) instead
@arthurpaulino arthurpaulino self-assigned this Mar 4, 2024
@arthurpaulino arthurpaulino linked a pull request Mar 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurpaulino arthurpaulino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use SymbolRef as the Lang map key lurk-lab/lurk-rs
1 participant
@arthurpaulino